Skip to content

Basic auth asio on Linux#97

Closed
ritzk wants to merge 2 commits intomicrosoft:testingfrom
ritzk:basic_auth_asio
Closed

Basic auth asio on Linux#97
ritzk wants to merge 2 commits intomicrosoft:testingfrom
ritzk:basic_auth_asio

Conversation

@ritzk
Copy link
Copy Markdown
Contributor

@ritzk ritzk commented Mar 17, 2016

Add support for basic auth for http_client_asio on Linux

    auto creds = web::http::client::credentials(user, password);
    client_config.set_credentials(creds);

    m_client = std::unique_ptr<web::http::client::http_client > \
        (new web::http::client::http_client (server, client_config));

    auto task = m_client->request(web::http::methods::POST, api_path);
    task.then([](web::http::http_response response) {
        std::cout << "response is " << response.to_string()  << "\n";
    });
    task.wait();

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 17, 2016

Hi @ritzk, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 17, 2016

@ritzk, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 19, 2016

@ritzk, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Mar 31, 2016

This looks solid. However, in order to merge, we will need to enable our basic auth tests to cover Linux as well.

@ras0219-msft ras0219-msft force-pushed the testing branch 2 times, most recently from 0dbc711 to 46dcdaa Compare May 19, 2016 19:07
@ritzk ritzk force-pushed the basic_auth_asio branch from 26f51a4 to a3b7165 Compare June 26, 2016 05:56
@ritzk
Copy link
Copy Markdown
Contributor Author

ritzk commented Jul 8, 2016

test case added.

@kavyako
Copy link
Copy Markdown
Contributor

kavyako commented Jul 27, 2016

Merged to development. The changes will be in the 2.9 release.

@kavyako kavyako closed this Jul 27, 2016
@moozzyk moozzyk mentioned this pull request Dec 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ritzk @msftclas @ras0219-msft @kavyako