Skip to content

Commit dee75e2

Browse files
feat: unmask exceptions on blob retrieve error (#10704)
These have not been encountered in at least three months, likely longer. Still remains to unmask exceptions when storing blobs. We are probably ready to do that, but log noise caused by expected failures makes it hard to be certain. Soon...
1 parent 3e23f16 commit dee75e2

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

ietf/doc/storage_utils.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,7 @@ def retrieve_bytes(kind: str, name: str) -> bytes:
178178
content = f.read()
179179
except Exception as err:
180180
log(f"Blobstore Error: Failed to read bytes from {kind}:{name}: {repr(err)}")
181-
if settings.SERVER_MODE == "development":
182-
raise
181+
raise
183182
return content
184183

185184

@@ -192,6 +191,5 @@ def retrieve_str(kind: str, name: str) -> str:
192191
content = content_bytes.decode("utf-8")
193192
except Exception as err:
194193
log(f"Blobstore Error: Failed to read string from {kind}:{name}: {repr(err)}")
195-
if settings.SERVER_MODE == "development":
196-
raise
194+
raise
197195
return content

0 commit comments

Comments
 (0)