Fix AST to include text for single line comments#2858
Merged
seven-phases-max merged 1 commit intoless:masterfrom Mar 31, 2016
zzzzBov:patch-1
Merged
Fix AST to include text for single line comments#2858seven-phases-max merged 1 commit intoless:masterfrom zzzzBov:patch-1
seven-phases-max merged 1 commit intoless:masterfrom
zzzzBov:patch-1
Conversation
Contributor
Author
|
Here's a quick little test I threw together: |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AST didn't include the contents of single line comments because of a tyop in a property name.
I used
to view the AST locally. I haven't yet written any tests for this particular case.