Plugins: If minVersion >= 3.0.0, don't "pre-run" .setOptions()#3247
Conversation
matthew-dean
left a comment
There was a problem hiding this comment.
@calvinjuarez I really like this. Much cleaner. Maybe remove .editorconfig? (I realize I made the opposite argument for the .vscode file, but that file was for launching tests, whereas this is config?)
Also, CI tests are failing?
|
.editorconfig is meant to be a way to share and enforce coding standards across editors. I can keep it out, but I think it has value in the repository. (See https://editorconfig.org). I don’t mind ignoring it, if it’s not seen as generally useful, but it’s a nice way for me to contribute using my preferred IDE and others to use theirs without having to manually change editor settings (I use tab indentation on my work and personal stuff, for example). As for the CI failures, I wondered about that. I’m not hip to CI, so I could use some help knowing how to review what’s broken so I can fix it. |
|
Okay, I think I see what the tests are verifying. I’ll try to test on all version soon of Node in the tests. Stay tuned. |
|
@calvinjuarez The error is the same as on main. Which is:
DERP. I see my mistake. Fixing. |
|
Please merge again from master and it should work. [crosses fingers] |
This is just what I was mentioning in #3233. Turned out to be simple enough. Tests were updated and a 3.x test was added. If no
minVersionis specified by a plugin,setOptions()is run twice to be safe. Maybe no specification should "assume v3+"? That could break more old plugins created without theminVersionproperty.