Skip to content

Color function updates - #RRGGBBAA and CSS Variables#3291

Merged
matthew-dean merged 4 commits intoless:masterfrom
matthew-dean:bugfix-3290
Jul 29, 2018
Merged

Color function updates - #RRGGBBAA and CSS Variables#3291
matthew-dean merged 4 commits intoless:masterfrom
matthew-dean:bugfix-3290

Conversation

@matthew-dean
Copy link
Copy Markdown
Member

@matthew-dean matthew-dean commented Jul 17, 2018

Fixes #3290, #2986, #3176, #1665

  • Allows #RRGGBBAA colors
  • Outputs color functions as-is when there are unrecognized properties (allows using CSS variables for args, for example)
  • Keeps colors in the same color space when possible. e.g. spin(hsl(50, 1%, 10%), 10) becomes hsl(60, 1%, 10%) vs converting to rgba()
  • Adds the rgba(<Color> [, <opacity>]) and hsla(<Color> [, <opacity>]) 1- or 2-argument forms for those functions

@matthew-dean matthew-dean changed the title Supports #RRGGBBAA color form Color function updates - #RRGGBBAA and CSS Variables Jul 18, 2018
@matthew-dean
Copy link
Copy Markdown
Member Author

Updated, see: #3290 (comment)

Copy link
Copy Markdown
Member

@calvinjuarez calvinjuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@matthew-dean
Copy link
Copy Markdown
Member Author

@calvinjuarez Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants