Fix #2991#3649
Merged
matthew-dean merged 3 commits intoless:masterfrom Aug 20, 2022
Merged
Conversation
Contributor
Author
|
Test failure seems to be a change of formatting of an error message in node 16. I don't see any relation to my changes. |
Member
|
@MoonCoral Yes, it's not your issue. |
Merged
Member
|
@MoonCoral Please update your branch, upstream master branch solved the CI problem. |
Contributor
Author
|
Rebased on master |
Member
|
@MoonCoral CI has been fixed, please update your work, thanks ! |
added 2 commits
November 15, 2021 17:18
Member
|
If all other tests pass, this seems good. |
matthew-dean
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2991
Only comments have
isSilentas far as I could see. No comment should cause a parent to be printed in the 'referenced' case.Thus I'm not even sure what the condition I deleted aimed to achieve.
Test is based on the snipped posted in #2991.
css-3.csscontained an empty@rule, I assume to bypass the issue raised in #2991.