Feature/encrypted files#39
Closed
mwoc wants to merge 6 commits intothejoshwolfe:masterfrom
Closed
Conversation
added 6 commits
August 9, 2016 13:54
It fails because compressionMethod is 0 because the file is empty, but compressedSize is non-zero because the file is encrypted
…ying to read zip containing an encrypted zero-byte file
…crypted file. Update tests to assert that encrypted files don't get read
…ed files now triggers an error instead of extracting the still-encrypted bytes
Owner
Owner
|
Thanks for the PR. I've now implemented this myself. The |
Owner
|
the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I continued with the work in #36, and now actually tried to solve #11 by letting
openReadStreamcall its callback with an error when trying to read an encrypted file.The reason for emitting events for the encrypted files anyway, is that it can still be relevant for the implementor to know that the file contains zip files. I've added a helper method
Entry.prototype.isEncryptedfor implementors to check whether or not a file is encrypted.