Change paths determination for CLI#1974
Merged
lukeapage merged 1 commit intoless:masterfrom May 2, 2014
Merged
Conversation
… undefined and break node
dominicbarnes
pushed a commit
to dominicbarnes/component-builder-less
that referenced
this pull request
Apr 14, 2014
lukeapage
added a commit
that referenced
this pull request
May 2, 2014
Change paths determination for CLI
Member
|
Thanks looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a slight modification to how paths are determined before loading a file. (in the node/cli env)
If
env.pathsdoes not exist, it introducesundefinedinto the array. This breaks in node v0.10+ by throwing an exception whenpath.joinis called. Secondly, this also checks for whether or not.has already been added to the list before appending it.Currently, I always have to make sure
pathsis defined in my LESS options, this eliminates that necessity. (since the defaults here are reasonable)