Added condition to check if HEX code contain only valid characters (issue #1015)#1976
Merged
lukeapage merged 3 commits intoless:masterfrom Jun 6, 2014
Merged
Added condition to check if HEX code contain only valid characters (issue #1015)#1976lukeapage merged 3 commits intoless:masterfrom
lukeapage merged 3 commits intoless:masterfrom
Conversation
Member
Member
|
I'm not sure how they could be merged. I would only make the error less specific and remove the length check.. e.g. this would catch #fffblack Where they have missed a space. |
Contributor
Author
|
Thank you for answers. Tomorrow I will fix it to cover missed space case and add better error text. |
Member
|
great thanks. |
lukeapage
added a commit
that referenced
this pull request
Jun 6, 2014
Added condition to check if HEX code contain only valid characters (issue #1015)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have fixed issue #1015. Less was recognizing HEX code of length 3 inside intended longer HEX code, where were invalid hexadecimal characters.
This is my first contribution to less.js, so if there is something I missed - please tell me, I will gladly improve it. Have a nice day,
Ondra