Remove the "done" message displayed at the end of the compilation with Rhino.#2019
Merged
lukeapage merged 1 commit intoless:masterfrom Jun 6, 2014
Merged
Conversation
Member
|
I agree, nod lessc doesn't output a message. |
lukeapage
added a commit
that referenced
this pull request
Jun 6, 2014
Remove the "done" message displayed at the end of the compilation with Rhino.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
The "done" message, displayed at the end of the compilation, is useless, in my opinion.
Moreover, in the context of a web application that computes the stylesheet when it is necessary (through lesscss-java, for instance), the done message is stored in the log of the application, meanwhile no bug has happened. I personally try to only display bugs and warning in the logs, in order to not pollute them.
That is why I suggest to remove this message.
What do you think?
Thanks,
Guillaume