Fix double handling of exceptions#2312
Merged
lukeapage merged 1 commit intoless:masterfrom Nov 26, 2014
ForbesLindesay:fix-double-exception-handling
Merged
Fix double handling of exceptions#2312lukeapage merged 1 commit intoless:masterfrom ForbesLindesay:fix-double-exception-handling
lukeapage merged 1 commit intoless:masterfrom
ForbesLindesay:fix-double-exception-handling
Conversation
Member
|
Thanks.. will release a patch release soon. |
lukeapage
added a commit
that referenced
this pull request
Nov 26, 2014
…dling Fix double handling of exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only effects the callback based code path. Consider code like:
In the case where less rendering succeeds. This should crash with the error "Ooops, I made a mistake" but instead it logs "error handler" and exists cleanly. This is because the initial error is incorrectly caught by the try catch block and given back to the callback.
This pull request fixes the bug.