percentage function should throw error if result would be NaN#2644
Merged
lukeapage merged 1 commit intoless:masterfrom Sep 17, 2015
Merged
percentage function should throw error if result would be NaN#2644lukeapage merged 1 commit intoless:masterfrom
percentage function should throw error if result would be NaN#2644lukeapage merged 1 commit intoless:masterfrom
Conversation
…loor, etc) and throw error on NaN. less#2553
lukeapage
added a commit
that referenced
this pull request
Sep 17, 2015
…2553 `percentage` function should throw error if result would be `NaN`
mishal
added a commit
to mishal/iless
that referenced
this pull request
Sep 18, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Percentage should work the same way as other math functions (round, floor,etc) and throw error on NaN. #2553